TableItemLocator, isSelected(ui)...

[Ali Anwar]

TableItemLocator tiloc = new TableItemLocator("Value");
tiloc.isSelected(ui);

Always return false even if TableItem is in selected state. It was working as expected with previous version.

[Phil Quitslund]

We are not able to reproduce this on our end. It is possible that this is a timing issue exposed by our sped up runtime. Could you try this style of assertion instead?

Code: Select all

ui.assertThat(tiloc.isSelected());

(Do note that as a general rule this is the preferred style of assertion since it is less prone to timing issues.)

Hope this helps!

[jyotisaxena]

Hi Phil,
I am also facing similar issue. I am trying to unselect one of the general eclipse preferences, which may or may not be already selected. But the TableItemLocator instance.isSelected(ui) is always returning false. Even though it is already selected, the assertion (ui.assertThat(tableItemLocator.isSelected(ui)))fails, ui.ensureThat(tableitemLocator.hasFocus()) results waitTimeOutException. Some help please.

[keertip]

Could you post the test code? Thanks!

[jyotisaxena]

Hi Phil,
This is the sample code which isn't working at line: cvsLocator.isSelected(ui)

public static void uncheckCVSDecorations(IUIContext ui) throws Exception {
ui.click(new MenuItemLocator("Window/Preferences"));
ui.wait(new ShellShowingCondition("Preferences"));
ui.click(new FilteredTreeItemLocator("General"));
ui.click(new FilteredTreeItemLocator(
"General/Appearance/Label Decorations"));
TableItemLocator cvsLocator = new TableItemLocator("CVS");
//Following condition is always true, hence the selection toggles.
if(!cvsLocator.isSelected(ui)){
ui.click(1,cvsLocator, WT.CHECK);
}
ui.click(new ButtonLocator("OK"));
ui.wait(new ShellDisposedCondition("Preferences"));
}

[keertip]

The tableItem.isSelected(ui) looks to see whether the item has been selected, and not if the item is checked, as in the case of a checked table item.
To find out whether the table item is checked, you can do the following

Code: Select all

      TableItemLocator cvsLocator = new TableItemLocator("CVS");
      IWidgetReference ref = (IWidgetReference) ui.find(cvsLocator);
      final Widget widget = (Widget) ref.getWidget();
      final boolean[] result = new boolean[1];
      Display.getDefault().syncExec(new Runnable() {
         @Override
         public void run() {
            if (widget instanceof TableItem){
               TableItem item = (TableItem) widget;
               result[0] = item.getChecked();
            }
         }
      });
      if(!result[0]){
         ui.click(1,cvsLocator, WT.CHECK);
      }


[jyotisaxena]

Thanks.

[keertip]

Great! Good to know that worked out.

[fredg]

Hi,

I was wondering why TableItemLocators and TreeItemLocators do not implement an isChecked() method.
Is there a good reason for it?

The workaround works, but it would be faster if the user could assert the checked state of TableItems and TreeItems with the inspection tool while recording.

Regards,

Fred

[keertip]

There is no good reason for not implementing this feature - it is on the list for future enhancements.

[fredg]

Good to hear that it's already on the list.
Is there a rough timeframe for this enhancement?

Is it going to be mentioned in future release notes (of beta versions)?

[keertip]

As of now, there is no time frame attached to the list. Will make a mention of it when it is done.