Errata: Section 2.8 Writing plug-in tests

[smithla]

Two small problems in the plug-in test code in section 2.8. of the Book and PDF. Both of these have been fixed it the downloadble examples, but do not yet appear in the errata page.

First, the line below is missing from the import statements.

import org.eclipse.core.runtime.jobs.Job;

Second, the waitForJobs method in the book seems to cause the test to hang

public void waitForJobs() {
while (!Job.getJobManager().isIdle())
delay(1000);
}

The correct method (from the downloaded code) is:

public void waitForJobs() {
while (Job.getJobManager().currentJob() != null)
delay(1000);
}

[bgruenba]

I found this problem myself. It seems that the issue is actually a known issue with Mylyn. There is a thread on dev.eclipse.org on exactly this issue.
http://dev.eclipse.org/mhonarc/lists/my ... 00072.html

[Dan Rubel]

Thanks for spotting this. I have updated the errata page and included a link to the Mylyn discussion

[tkubaska]

I noticed the missing import statement also but the

Code: Select all

public void waitForJobs() {
   while(!Job.getJobManager().isIdle())
      delay(1000);
}

does not cause the test to hang for me. The test runs fine. But then I have not installed Mylyn in this Eclipse instance.

Also interesting that (when you don't have the import) selecting Job, right clicking, choosing Source->Add Import puts in the correct import statement.

In spite of Eric's advice to the contrary, I'm still using 3.5M5 on Linux. I haven't noticed problems so far other than the UI for adding the update site which was more of an annoyance than a problem.