GF/ST Color Problem in Buttons (resolved)

[tstalzer]

Hi

I think there is a little bug in the drawing of buttons using GF/St. This can be verified by the forward/back buttons in the Calendar Example.

The buttons get drawn with a black background instead of the current button background.

I believe that using "RGBColor white" in the method GFButtonGO->fromGO: should be changed to "CgRGBColor white". So, the method should be:

Code: Select all

fromGO: go

   "Answer a new instance of the receiver"

   | button bitmap mask |
   button := self new.
   bitmap := GFOpaqueBitmap screenExtent: go displayBox extent.
   mask := GFPixmap screenExtent: go displayBox extent.
   mask pen fill: mask boundingBox color: CgRGBColor white.
   go displayWith: bitmap pen at: 0@0.
   go displayShapeWith: mask pen at: 0@0.
   bitmap setMask: mask.
   button origin: go displayBox origin copy image: bitmap.

   ^button

--Thomas

[tstalzer]

Oh - I forgot.

This is 8.02

[wembley]

Thomas -

Actually what is missing is an update to WbKernel class>>#loaded

Code: Select all

loaded
   " WbKernel loaded "
   WbImageManager initializeImageCaches.
   RGBColor initializeOnLoad

and WBKernel class>>#removing

Code: Select all

removing
   " WbKernel removing "
   WbImageManager initializeImageCaches.
   RGBColor
      black: nil;
      white: nil

Don't forget to run RGBColor initializeOnLoad after you make the change. Case 46924 opened and fixed.

[tstalzer]

Hi John

Short Feedback - it works

Thanks

--Thomas