Suggested Change for QA Code Tools Framework (resolved)

[koschate]

I'd like to suggest the removal of the methods #defaultTextMenu and #menuEdit from CtResultsBrowser in the application CtUserInterfaceES. They effectively replicate functionality from EtWindow, and prevent proper modification by the text menus by add-ons such as the refactoring browser. Removing those methods makes it much easier to refactor code problems identified by the code review tool, since the refactoring can be invoked right from results browser.

[wembley]

Thomas -

Yes, they "almost" duplicate the EtWindow version of the methods. There are a couple important differences though. These generally have to do with whether particular menu items are enabled or not. It would be very possible to parameterize the enablement tests that are not already parameterized in EtWindow to make removal of these 2 methods possible. I've opened case 46899 for these changes.

[wembley]

Thomas -

I have attached a zip file of a .DAT containing 2 apps:

EtBaseTools
CtUserInterface

These apps are updates to V8.0.2, so if you are running an earlier version you may need to make some slight adjustments. Please let me know if these changes are what you had in mind.

[koschate]

Thanks, John. I'll have a look when I'm back in the office next week. If only there were an OSX version of VA, then I could have a look now.

[koschate]

Please let me know if these changes are what you had in mind.

John, the changes look good in my 8.0.2 image. I'll see about backporting to 7.5.2 for our immediate use here.