[8.0.2] EsCompiler>>useWarningLevel0While:

VA Smalltalk is a "100% VisualAge compatible" IDE that includes the original VisualAge technology and the popular VA Assist and WidgetKit add-ons.

Moderators: Eric Clayberg, wembley, tc, Diane Engles, solveig

[8.0.2] EsCompiler>>useWarningLevel0While:

Postby g.cotelli » Mon May 31, 2010 6:40 am

Hi,
I usually change this method because if something fails in the block evaluation the warning level remains in 0 because there's no ensure: . Maybe this change can be included in the base version.

Original Code:
Code: Select all
useWarningLevel0While: aBlock
   "Evaluate @aBlock whilst the default warning level is temporarily
   set to level 0.  Answer the result of evaluating @aBlock."

   | level result |

   level := self defaultWarningLevel.
   self defaultWarningLevel: 0.
   result := aBlock value.
   self defaultWarningLevel: level.
   ^result

Changed Code:
Code: Select all
useWarningLevel0While: aBlock
   "Evaluate @aBlock whilst the default warning level is temporarily
   set to level 0.  Answer the result of evaluating @aBlock."

   | level |

   level := self defaultWarningLevel.
   self defaultWarningLevel: 0.
   ^[aBlock value] ensure: [self defaultWarningLevel: level]


Regards,
Gabriel
g.cotelli
 
Posts: 13
Joined: Wed Feb 24, 2010 9:30 am

Re: [8.0.2] EsCompiler>>useWarningLevel0While:

Postby wembley » Tue Jun 01, 2010 7:52 am

Case 46659 opened and fixed (as suggested) in V8.0.3 first development build.
John O'Keefe [|], Principal Smalltalk Architect, Instantiations Inc.
wembley
Moderator
 
Posts: 405
Joined: Mon Oct 16, 2006 3:01 am
Location: Durham, NC


Return to VA Smalltalk 7.0, 7.5 & 8.0

Who is online

Users browsing this forum: No registered users and 1 guest