VA801 - Bugs

[marten]

Lets start with the new class browser:

- select a method
- delete the selected method
- select another method and you will see, that the content of the tab "Method Source" will not change any more ...

(using VA8.01 under Windows 7 Home Premium 64bit)

[tc]

Hello,

I am on xp, however, I was unable to replicate the problem following your steps. I'll try them on other platforms.

Thanks.

--tc

[tc]

Hello,

We tried your steps on Windows 7 Ultimate (32-bit) and did not see the error.

More precisely, what is your configuration (such as a MAC, wine, etc.)?

Thanks.

--tc

[marten]

You may look at: http://blip.tv/file/2972874 and there are times, where I actually do not work under strange environments like Linux or Mac or Wine - but under real Windows 7 HomePremium 64 bits after the launch with a virgin image ))

[tc]

Hello,

Nice video! I was able to reproduce the problem. I made the following change to fix it:

Code: Select all

StsTabbedApplicationsBrowserWin>>#selectListItems:clientData:callData:
   | result |
   
   result := self isMethodSelected.

   super perform: clientData with: callData selectedItems.

   self isMethodSelected = result
      ifFalse: [
         self textSelector: #methodSourceString.
         super perform: clientData with: callData selectedItems ].

   self isMethodSelected
      ifTrue: [
         self sourceCodeCommentNotebookPage labelString: self class methodCommentPageLabel.
         self sourceCodeNotesNotebookPage labelString: self class methodNotesPageLabel ]
      ifFalse: [
         self sourceCodeCommentNotebookPage labelString: self class classCommentPageLabel.
         self sourceCodeNotesNotebookPage labelString: self class classNotesPageLabel ].

   sourceCodeNotebookTabSelected isNil
      ifTrue: [ ^nil ].

   sourceCodeNotebookTabSelected name = self class versionGraphPageName
      ifTrue: [ 
         sourceTextWidget parent unmanageChild.
         drawingAreaFormWidget manageChild.
         self generateVersionGraph ]

. . . however, I am very leery of a change like this because there is a lot of state to deal with, so, my approach has been, not to deal with it. Since the text pane is controlled by the super classes, let them deal with it. As soon as a change like the above is made, another issue pops up and pretty soon, the browser class, rather than the super class(-es) is/are dealing with way more state changes than it should.

The long term approach is to remove more class functionality and let the super classes handle things.

--tc

[tc]

Hello,

I created case 44534 for this issue.

Thanks.

--tc

[marten]

This has not been fixed in 8.0.2 ?

Hello,

I created case 44534 for this issue.

Thanks.

--tc

[tc]

Hello,

It was tagged for build 140 and mentioned again for build 144. I'm not sure why it was not put in but will check.

--tc

[tc]

Hello,

The change/fix went into the 'StsTabbedApplicationsBrowserWin' (with an 's' on 'Application') which is a shadow browser.

The change will be in the 'StsTabbedApplicationBrowserWin' (no 's' on 'Application') in the next release.

Thanks.

--tc