Possible Bug in #differencesWith:includeSubApplications:

VA Smalltalk is a "100% VisualAge compatible" IDE that includes the original VisualAge technology and the popular VA Assist and WidgetKit add-ons.

Moderators: Eric Clayberg, wembley, tc, Diane Engles, solveig

Possible Bug in #differencesWith:includeSubApplications:

Postby rjs » Thu Nov 27, 2008 7:44 am

SubApplication class>>#differencesWith:includeSubApplications: (1997/07/25 15:26:24) seems to have a bug in handling sup-applications in the "other" edition that aren't in the base edition.

Specifically, using "otherSub" in the following code re-uses the last common sub-application name instead of the name of the other, uncommon name.
Code: Select all
   "For each subApplication in other that does not exist in the receiver, use an empty
   shadow to record the entire subApplication as different."

   otherSubApps do: [:sub |
      shadowSub := SubApplication shadowClass
         named: otherSub symbol
         timeStampWithVersionInfo: EmTimeStamp undefined.
         at: sub
         put: (Association key: shadowSub value: (shadowSub differencesWith: sub))].
Posts: 39
Joined: Thu Mar 27, 2008 11:07 am
Location: Port Perry, Ontario, Canada

Re: Possible Bug in #differencesWith:includeSubApplications:

Postby wembley » Fri Nov 28, 2008 9:15 am

Yes, it appears that 'otherSub' should be 'sub' in the code snippet. I have opened defect 38170 for this problem -- fixed in V8,0.0.
John O'Keefe [|], Principal Smalltalk Architect, Instantiations Inc.
Posts: 405
Joined: Mon Oct 16, 2006 3:01 am
Location: Durham, NC

Return to VA Smalltalk 7.0, 7.5 & 8.0

Who is online

Users browsing this forum: Yahoo [Bot] and 1 guest