Unreleased subapplications not visible in App Mgr

VA Smalltalk is a "100% VisualAge compatible" IDE that includes the original VisualAge technology and the popular VA Assist and WidgetKit add-ons.

Moderators: Eric Clayberg, wembley, tc, Diane Engles, solveig

Unreleased subapplications not visible in App Mgr

Postby Thomas Holzer » Fri Nov 21, 2008 2:19 am

Hello,

the VA 7.5 Application Manager does not show wether the currently loaded subapplication is released or not. This Problem leads to lost code changes, because the loaded subapplication are considered as released. But in the next load of the image they are lost again. :shock:

The VA 4.5 Application Manager shows unreleased classes with a greater then character “>”.

How can I use the old behavior? :?:

Regards

Thomas Holzer
Thomas Holzer
 
Posts: 16
Joined: Fri Nov 21, 2008 2:14 am

Re: Unreleased subapplications not visible in App Mgr

Postby Eric Clayberg » Fri Nov 21, 2008 4:46 am

Thomas Holzer wrote:the VA 7.5 Application Manager does not show wether the currently loaded subapplication is released or not.

That is not true. The VA Assist browsers in VA 7.5 indcate item state with special icons and colors. Unreleased subapps are shown with a green folder icon.

See p9 of the VA Assist User's Guide (vaast75.pdf) in the VAST /readme subdirectory.

Thomas Holzer wrote:The VA 4.5 Application Manager shows unreleased classes with a greater then character “>”.

Unversioned classes are shown in blue, scratched classes in red and unreleased classes in green. See the Options > Enhanced List Widgets > Show Item colors > Show Unreleased Classes option.

Thomas Holzer wrote:How can I use the old behavior?

Turn off the Options > Enhanced List Widgets > Use Enhanced List Widgets option.
Eric Clayberg
Software Engineering Manager
Google
http://code.google.com/webtoolkit/download.html

Author: "Eclipse Plug-ins"
http://www.qualityeclipse.com
Eric Clayberg
Moderator
 
Posts: 4503
Joined: Tue Sep 30, 2003 6:39 am
Location: Boston, MA USA

Re: Unreleased subapplications not visible in App Mgr

Postby wembley » Fri Nov 21, 2008 5:31 am

Thomas -

The code that displays the infoIndicator ('>' by default) in the standard browsers hasn't changed since about 1996. So, here are some things to look at:

* What do you see on the Transcript when you display EtTools infoIndicator?

* What do you see on the Transcript when you display EtTools browserMappings?

* If you are using VA Assist browsers, please attach a screen capture of the window displayed when selecting Tools -> VA Assist Pro -> Settings -> Enhanced List Widgets -> Configure... from the Transcript menu.
John O'Keefe [|], Principal Smalltalk Architect, Instantiations Inc.
wembley
Moderator
 
Posts: 405
Joined: Mon Oct 16, 2006 3:01 am
Location: Durham, NC

Re: Unreleased subapplications not visible in App Mgr

Postby jtuchel » Fri Nov 21, 2008 8:05 am

Eric,

I think you both are right. Unreleased subapps are shown in colours. BUT if subapps of an app are unreleased and the app is not expanded in the class manager or even in the organizer, there is no indication.

... not completely sure if Thomas meant this.

joachim
jtuchel
[|]
 
Posts: 245
Joined: Fri Oct 05, 2007 1:05 am
Location: Ludwigsburg, Germany

Re: Unreleased subapplications not visible in App Mgr

Postby Thomas Holzer » Fri Nov 21, 2008 8:06 am

Hi John,

Thank you for your fast response.

Strange, but in my development image all open editions of applications and subapplications are green? Please see the enclosed screenshot where all subapplications are released.

Hmm what have I done wrong?

Regards Thomas Holzer

P.S.

EtTools infoIndicator '>'
EtTools browserMappings results for application StsApplicationBrowser
Attachments
vast release problem.jpg
vast release problem.jpg (74.25 KiB) Viewed 703 times
Thomas Holzer
 
Posts: 16
Joined: Fri Nov 21, 2008 2:14 am

Re: Unreleased subapplications not visible in App Mgr

Postby Thomas Holzer » Wed Nov 26, 2008 1:26 am

Hi,

Anything new? I still cannot use the new colored items and see if a sub app is released or not. In both cases it shows the green icon :shock: (Please see above screenshot).

Greetings Thomas
Thomas Holzer
 
Posts: 16
Joined: Fri Nov 21, 2008 2:14 am

Re: Unreleased subapplications not visible in App Mgr

Postby jkoepp » Wed Nov 26, 2008 7:05 am

In my 7.0 image things happens like this:

Responsible for enhancedListWidget Display in the ApplicationManager is StsApplicationManager>>#stsStatusBlockFor: which calls StsApplicationManager class>>#stsCacheEntriesFor: where color and image are choosen. Unreleased Subapplications are treated like normal editions. You only see the difference when loading an unreleased application version. Then you see the green folder not the normal yellow one for versions.

EtTools class>>#infoIndicator is used by EtApplicationManager>>#applicationStatusIndicatorBlock but is not used with enhanced List Widgets. (We can place a breakpoint in this method - nothing happens)

What can be done is patching #stsCacheEntriesFor:
For example a red text color for unreleased subapps like scratch editions:

Code: Select all
StsApplicationManager class

stsCacheEntriesFor: app

   | colorApplicationEditions image color |

   image := ImageCache at: app ifAbsent: [nil].
   color := ColorCache at: app ifAbsent: [nil].
   image notNil & color notNil
      ifTrue: [^Association key: image value: color].

   color := (StsPowerTools useItemColors
      and: [(colorApplicationEditions := StsPowerTools colorApplicationEditions) notNil])
      ifTrue: [
         (app isSubApplication and: [(EtTools managerInterface isSubApplicationReleased: app in: app parent) not])
            ifTrue: [StsPowerTools colorApplicationScratchEditions]
            ifFalse: [
               app isEdition
                  ifTrue: [colorApplicationEditions]
                  ifFalse: [
                     app isScratch
                        ifTrue: [StsPowerTools colorApplicationScratchEditions]
                        ifFalse: [nil]]]]
      ifFalse: [nil].
   
   image := app isScratch
      ifTrue: [self stsImageNamed: StsPowerTools iconScratchApplications]
      ifFalse: [
         ((self stsSuperUser or: [app manager == EmUser current])
            and: [app isEdition or: [app isSubApplication and: [(EtTools managerInterface isSubApplicationReleased: app in: app parent) not]]])
            ifTrue: [self stsImageNamed: StsPowerTools iconModifiedApplications]
            ifFalse: [
               (StsPowerTools showScratchApplicationHierarchies not
                  or: [app withAllSubApplications conform: [:each | each isScratch not]])
                  ifTrue: [self stsImageNamed: StsPowerTools iconApplications]
                  ifFalse: [self stsImageNamed: StsPowerTools iconScratchApplications]]].

   ImageCache at: app put: image.
   ColorCache at: app put: color.
   ^Association key: image value: color

Juergen
jkoepp
 
Posts: 9
Joined: Mon Mar 31, 2008 4:40 am

Re: Unreleased subapplications not visible in App Mgr

Postby Thomas Holzer » Wed Dec 03, 2008 1:33 am

Hello Jürgen,

very nice, thank you very much! Your code shows now the unreleased sub apps in red color. :)
@Instantiations could you please check, if this fix could be included in VA 8.0?

Regards Thomas
Thomas Holzer
 
Posts: 16
Joined: Fri Nov 21, 2008 2:14 am

Re: Unreleased subapplications not visible in App Mgr

Postby wembley » Wed Dec 03, 2008 10:25 am

Thomas and Juergen -

We will update StsApplicationManager in some way for V8 to indicate the difference between a released and unreleased subapplication -- Case38222.
John O'Keefe [|], Principal Smalltalk Architect, Instantiations Inc.
wembley
Moderator
 
Posts: 405
Joined: Mon Oct 16, 2006 3:01 am
Location: Durham, NC


Return to VA Smalltalk 7.0, 7.5 & 8.0

Who is online

Users browsing this forum: Yahoo [Bot] and 1 guest