VA Smalltalk is a "100% VisualAge compatible" IDE that includes the original VisualAge technology and the popular VA Assist and WidgetKit add-ons.
Moderators: Eric Clayberg, wembley, tc, Diane Engles, solveig
by nmongeau » Thu Jul 19, 2007 12:19 pm
Hi,
I stumbled upon a small handle leak in the base image: senders of
OSCall>>createProcess: lpApplicationName
lpszCommandLine: lpCommandLine
lpsaProcess: lpProcessAttributes
lpsaThread: lpThreadAttributes
fInheritHandles: bInheritHandles
fdwCreate: dwCreationFlags
lpvEnvironment: lpEnvironment
lpszCurDir: lpCurrentDirectory
lpsiStartInfo: lpStartupInfo
lppiProcInfo: lpProcessInformation
are supposed to close 2 handles when they are done. This is not happening in the base image.
Normand
-
nmongeau
- [|]
-
- Posts: 29
- Joined: Fri Jan 12, 2007 9:37 am
by wembley » Fri Jul 20, 2007 11:00 am
Normand -
OK, I need a little more of a clue since I've read the MSDN doc on createProcess:.... and I don't see anything about handles that need to be released.
John O'Keefe [|], Principal Smalltalk Architect, Instantiations Inc.
-
wembley
- Moderator
-
- Posts: 405
- Joined: Mon Oct 16, 2006 3:01 am
- Location: Durham, NC
-
by nmongeau » Fri Jul 20, 2007 11:29 am
Here's what my doc says about the last argument to the API:
lpProcessInformation
[out] A pointer to a PROCESS_INFORMATION structure that receives identification information about the new process.
Handles in PROCESS_INFORMATION must be closed with CloseHandle when they are no longer needed.
Normand
-
nmongeau
- [|]
-
- Posts: 29
- Joined: Fri Jan 12, 2007 9:37 am
by wembley » Fri Jul 20, 2007 11:47 am
Yep, read too fast
I will make a note of this for a future fixpack.
John O'Keefe [|], Principal Smalltalk Architect, Instantiations Inc.
-
wembley
- Moderator
-
- Posts: 405
- Joined: Mon Oct 16, 2006 3:01 am
- Location: Durham, NC
-
by cwolcott » Wed Aug 15, 2007 5:37 pm
John,
Could you publish this separately when there is a fix made? I am sure the leak is small, but we are getting ready to install JAS on 100 node cluster and will be easily kicking off 200 simulation daily and thus the leak will could cause an issue over time.
.
Chris Wolcott
Simulation Domain Lead
Joint Analysis Simulation (JAS)
-
cwolcott
- [|]
-
- Posts: 11
- Joined: Fri Jan 26, 2007 10:51 am
- Location: Arlington, VA
by wembley » Wed Aug 15, 2007 5:51 pm
Will do
John O'Keefe [|], Principal Smalltalk Architect, Instantiations Inc.
-
wembley
- Moderator
-
- Posts: 405
- Joined: Mon Oct 16, 2006 3:01 am
- Location: Durham, NC
-
Return to VA Smalltalk 7.0, 7.5 & 8.0
Who is online
Users browsing this forum: Yahoo [Bot] and 1 guest